Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "View page history" link to every page #78

Merged
merged 1 commit into from Jul 4, 2022

Conversation

llewelld
Copy link
Member

Adds a link to the bottom of each page, next to the "Edit this page on
GitHub" link, which links through to the github commit history. Can be
controlled using the _config.yml file.

See JB#57952

@llewelld llewelld requested review from sledges and Thaodan May 10, 2022 08:42
_config.yml Outdated Show resolved Hide resolved
@Thaodan
Copy link
Contributor

Thaodan commented May 10, 2022

Shoudn't it be view history instead of change history?

@rainemak
Copy link
Member

Shoudn't it be view history instead of change history?

Not necessarily. "Change history" can be treated as action toward history or like here "see how it has changed over time".

@rainemak
Copy link
Member

Once agreed, please update also commit title and PR title.

Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already while back when I tested this last time but change looks still the same. Hence, approving.

Adds a link to the bottom of each page, next to the "Edit this page on
GitHub" link, which links through to the github commit history. Can be
controlled using the _config.yml file.

See JB#57952
@llewelld llewelld changed the title Add Changelog link to every page Add "View page history" link to every page Jul 4, 2022
@llewelld
Copy link
Member Author

llewelld commented Jul 4, 2022

I agree with both: "Change history" was intended to mean "View the change history", but since it was demonstrably a bit unclear I've modified it to "View page history", which hopefully is clearer.

I've made this change, updated the commit title and the PR title, and tested it locally (it works as before). The changes are minor, so I'll go ahead and merge.

@llewelld llewelld merged commit 57c5693 into sailfishos:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants