Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove sailfish-devicelock-fpd from droid-configs on local build #81

Merged
merged 3 commits into from May 13, 2022

Conversation

Thaodan
Copy link
Contributor

@Thaodan Thaodan commented May 10, 2022

The dependencies for it namely sailfish-fpd-slave binder are now in
hw-common making sailfish-fpd also work for local builds.

Copy link
Contributor

@sledges sledges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump 4.3.0.15 versions to 4.4.0.58, and also remove this snippet from Android 11: (but is not available for the community build, however potential fix effort is ongoing for a release after 4.3.0)

nit: Dont -> Don't

@Thaodan Thaodan requested a review from sledges May 12, 2022 00:20
@sledges sledges changed the title Dont remove sailfish-devicelock-fpd from droid-configs on local build Don't remove sailfish-devicelock-fpd from droid-configs on local build May 12, 2022
The dependencies for it namely sailfish-fpd-slave binder are now in
hw-common making sailfish-fpd also work for local builds.
Since the sailfish-fpd-slave is in hw-common.
@Thaodan Thaodan merged commit 7eb47be into master May 13, 2022
@Thaodan
Copy link
Contributor Author

Thaodan commented May 13, 2022

Rebased and merged.

@github-pages github-pages bot temporarily deployed to github-pages May 13, 2022 08:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants