[doxygen] Update to 1.9.5. Fixes JB#59742 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would have liked to have changes related to submodule packaging and cmake in separate commits, but that would have made things unnecessarily complex as the old version could not be built with submodule packaging, the old version could not be built with cmake and the new version could not be built without cmake. |
martyone
approved these changes
Dec 13, 2022
rpm/doxygen.spec
Outdated
| %make_build | ||
|
|
||
| %install | ||
| rm -rf %{buildroot} |
There was a problem hiding this comment.
It's deprecated to rm buildroot, %install already does it.
rpm/doxygen.spec
Outdated
|
|
||
| %files | ||
| %defattr(-,root,root,-) | ||
| %attr(755,root,root) /usr/bin/* |
There was a problem hiding this comment.
%{_bindir} should be used and it's common to omit %attr here - I believe the files are already installed with correct permissions by cmake.
There was a problem hiding this comment.
fixed. Also added the filename, there is only one binary.
Also changed to use submodule packaging and CMake. Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed to use submodule packaging and CMake.
Signed-off-by: Ville Nummela ville.nummela@jolla.com