Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a hack as the title says.
There are two observations around current camera2 initialization that this fixes:
The fix for this was to make a copy of the params and re-apply them when actual requests are alive
exposure-compensationis part of only ONE initial set of params sent from gst-droid, and not the second one. So there are at least TWO param updates before at least the preview request is alive, and only the first one has the exposure. The fix was to always propagate the first exposure-compensation sent until the copied params are applied at actual initialization.I realize this is not a fix at all - it is just some info.
It does help me with 1. applying edge-mode and noisereduction initially and 2. applying the previous exposure