Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[droidmedia] Rewrite miniaudiopolicy to spawn a fake service. JB#56158 #92

Merged
merged 3 commits into from Jul 14, 2022
Merged

[droidmedia] Rewrite miniaudiopolicy to spawn a fake service. JB#56158 #92

merged 3 commits into from Jul 14, 2022

Conversation

Thaodan
Copy link
Contributor

@Thaodan Thaodan commented Oct 31, 2021 •
edited

The old miniaudiopolicy spawned a full instance auf audiopolicy spawn
a fake instance that does nothing instead.

This was referenced Oct 31, 2021
Closed
Merged
@mlehtima mlehtima mentioned this pull request Oct 31, 2021
Closed
@Thaodan Thaodan mentioned this pull request Oct 31, 2021
Merged
@rinigus
Copy link

rinigus commented Nov 2, 2021

When building for ports using rpm/dhd/helpers/pack_source_droidmedia-localbuild.sh, I don't see how would MINIMEDIA_AUDIOPOLICYSERVICE_ENABLE := 1 propagate and will be involved in creating generated SPEC. Or there is a plan for adjusting that pack_source script as well?

@mlehtima
Copy link
Contributor

mlehtima commented Nov 2, 2021

@rinigus you mean like this mer-hybris/droid-hal-device#311

@rinigus
Copy link

rinigus commented Nov 3, 2021

@mlehtima: yes, exactly that. So, droidmedia SPEC generation is covered via that PR in drod-hal-device. Now we need somehow to document that MINIMEDIA_AUDIOPOLICYSERVICE_ENABLE := 1 has to be added to local env.sh for localbuild case.

@Thaodan
Copy link
Contributor Author

Thaodan commented Nov 3, 2021 •
edited

@mlehtima: yes, exactly that. So, droidmedia SPEC generation is covered via that PR in drod-hal-device. Now we need somehow to document that MINIMEDIA_AUDIOPOLICYSERVICE_ENABLE := 1 has to be added to local env.sh for localbuild case.

I didn't add anything else so far since it was already required before to enable before but its something worth to add.

@Thaodan
Copy link
Contributor Author

Thaodan commented Feb 19, 2022

Required PR for this:

@Thaodan Thaodan force-pushed the jb56158 branch 8 times, most recently from f2663ed to 4d3e87d Compare June 5, 2022 18:14
@Thaodan Thaodan changed the title [droidmedia] miniaudiopolicy in a separate binary. JB#56158 [droidmedia] Rewrite miniaudiopolicy to spawn a fake service. JB#56158 Jun 5, 2022
@Thaodan Thaodan force-pushed the jb56158 branch 8 times, most recently from 7261d43 to 6da4785 Compare June 7, 2022 00:58
@Thaodan
Copy link
Contributor Author

Thaodan commented Jun 7, 2022 •
edited

Update to support Android 6, 7, 8.1 and 9 in addition to Android 10 and 11.
Enable FakeAudioPolicy by default since it is no longer starting the full audiopolicy service.

abranson
abranson reviewed Jun 7, 2022
View reviewed changes
miniaudiopolicy.cpp Outdated Show resolved Hide resolved
@Thaodan Thaodan force-pushed the jb56158 branch 16 times, most recently from ba58927 to 9107e95 Compare June 8, 2022 00:04
abranson
abranson reviewed Jun 8, 2022
View reviewed changes
rpm/droidmedia.spec Outdated Show resolved Hide resolved
abranson
abranson reviewed Jun 8, 2022
View reviewed changes
init/miniaf.rc Outdated
@@ -0,0 +1,4 @@
service miniaf /usr/libexec/droid-hybris/system/bin/miniafservice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be somewhere else? It's not built here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yes I think so. I'll move it.

@Thaodan
[droidmedia] Move rc files for fake services to droidmedia
a528939 
Separating each fake service into its own rc file is cleaner.

Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
@Thaodan
[droidmedia] Rewrite miniaudiopolicy to spawn a fake service. JB#56158
a0ee3d5 
The old miniaudiopolicy spawned a full instance auf audiopolicy spawn
a fake instance that does nothing instead.

Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
@Thaodan
[droidmedia] Move rc files for fake services to droidmedia
7387627 
Separating each fake service into its own rc file is cleaner.

Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
@Thaodan Thaodan merged commit 5ed6f69 into master Jul 14, 2022
@Thaodan Thaodan deleted the jb56158 branch July 22, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abranson abranson abranson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Thaodan @rinigus @mlehtima @abranson