[embedlite-components] Make selection handling more robust. Fixes JB#58662 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…58662 When trying to copy to clipboard without selection following got triggered: > JavaScript error: chrome://embedlite/content/SelectionHandler.js, > line 310: TypeError: this._cache.selection is undefined Fix: return early if no cache or selection. On error case following got triggered: > JavaScript error: chrome://embedlite/content/SelectionHandler.js, > line 66: TypeError: aJson is undefined Fix: have json argument in all this.sendAsync calls. Signed-off-by: Raine Makelainen <raine.makelainen@jolla.com>
llewelld
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
This also LGTM. I could reproduce the bug before (empty copies causing future link selections to fail), but couldn't reproduce it after.
I wondered if maybe it would make sense to call Content:SelectionCopied with succeeded = false in the early return case, but looking at WebView.qml there wouldn't be any point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to copy to clipboard without selection following got triggered:
Fix: return early if no cache or selection.
On error case following got triggered:
Fix: have json argument in all this.sendAsync calls.
Signed-off-by: Raine Makelainen raine.makelainen@jolla.com