Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'Z' ANSI sequence #3

Merged
merged 2 commits into from Feb 7, 2022

Conversation

direc85
Copy link
Contributor

@direc85 direc85 commented Feb 5, 2022

This fixes scrolling issues, e.g. editing long lines of text in nano.

Copy link
Member

@llewelld llewelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice contribution; it seems to work well. Could you please amend the commit title to the following, so that we can tie it to our internal bug report:

Implement 'Z' ANSI sequence. Fixes JB#57350

terminal.cpp Outdated Show resolved Hide resolved
@direc85 direc85 changed the title Implement 'Z' ANSI sequence Implement 'Z' ANSI sequence. Fixes JB#57350 Feb 7, 2022
@direc85 direc85 changed the title Implement 'Z' ANSI sequence. Fixes JB#57350 Implement 'Z' ANSI sequence Feb 7, 2022
This fixes scrolling issues, e.g. editing long lines of text in nano.
Co-authored-by: David Llewellyn-Jones <david@flypig.co.uk>
@direc85 direc85 requested a review from llewelld February 7, 2022 16:17
Copy link
Member

@llewelld llewelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. This looks good to me.

Thanks again for contributing a nice fix.

@llewelld llewelld merged commit 14342be into sailfishos:master Feb 7, 2022
@llewelld
Copy link
Member

llewelld commented Feb 7, 2022

Just for your info, this change is unlikely to make it into the next release, but should now be in the one following it.

@direc85
Copy link
Contributor Author

direc85 commented Feb 7, 2022

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants