Gecko camera fixes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up the video encoder to produce a constant bitrate stream because the VBR stream that is generated by default conflicts with internal WebRTC bandwidth limiting algorithms.
After this commit is applied, gecko-camera will read /proc/cpuinfo, guess CPU vendor, and only use media buffers on MediaTek devices. The behavior can be controlled regardless of CPU vendor using the following environment variables: GECKO_CAMERA_DROID_FORCE_MEDIA_BUFFER=1 - use media buffers GECKO_CAMERA_DROID_NO_MEDIA_BUFFER=1 - not use media buffers
mkosola
approved these changes
Jun 5, 2023
This was referenced Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[gecko-camera] Use media buffers depending on CPU vendor. JB#56755
[gecko-camera] Set up the video encoder to produce CBR stream. JB#57733