[sailfishos][embedlite] Add a content controller stack. Fixes JB#57690 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainemak
reviewed
Mar 24, 2022
rainemak
reviewed
Mar 24, 2022
rainemak
reviewed
Mar 24, 2022
rainemak
reviewed
Mar 24, 2022
rainemak
reviewed
Mar 24, 2022
rainemak
reviewed
Mar 24, 2022
rainemak
reviewed
Mar 24, 2022
rainemak
reviewed
Mar 30, 2022
rainemak
reviewed
Mar 30, 2022
rainemak
reviewed
Mar 31, 2022
rainemak
reviewed
Mar 31, 2022
rainemak
reviewed
Mar 31, 2022
When multiple WebView componennts are used in an app, since there is only one compositor, only one can be in direct use at a time. This will be the last that was set as active. When the currently activated component is deactivated, the WebView that was active prior to that should be reinstanted. In particular, the view's GeckoContentController needs to be reinstated. This change adds a stack for managing the content controllers, so that previously active controllers can be reactivated. Co-authored-by: Raine Mäkeläinen <raine.makelainen@jolla.com>
|
Squashed and rebased. |
rainemak
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple WebView componennts are used in an app, since there is
only one compositor, only one can be in direct use at a time. This will
be the last that was set as active.
When the currently activated component is deactivated, the WebView that
was active prior to that should be reinstanted. In particular, the
view's GeckoContentController needs to be reinstated.
This change adds a stack for managing the content controllers, so that
previously active controllers can be reactivated.