[sailfishos][build] Enable elf-hack. Fixes JB#57563 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llewelld
force-pushed
the
jb57563
branch
2 times, most recently
from
3cabcd1
to
e960500
Compare
llewelld
changed the title
|
I had to make some additional changes to get this to work across all platforms.
|
|
Rebased. |
krnlyng
approved these changes
Apr 6, 2022
|
Rebase before merging. Let's get this to the master. |
Fixes elfhack to use 64 bit file positions, since otherwise the position variables overflow. Disables the elfhack tests during the build since these fail to execute correctly under quemu, although they run fine on real arm hardware. Note that the CROSS_COMPILE define isn't set because HOST is the same as TARGET when building using the Sailfish SDK. In addition, the following two upstream changes are applied. 1. mozilla/gecko-dev@8918f41 2. mozilla/gecko-dev@523b155 Details of these follow. commit 8918f41 Author: Mike Hommey <mh+mozilla@glandium.org> Date: Wed Dec 29 01:18:29 2021 +0000 Bug 1495733 - Use a 64-bits internal representation in elfhack. r=gsvelto Elfhack currently can't deal with files larger than 4GiB because it translates all ELF data structures to the 32-bits variant, even for 64-bits ELF files. So if the original file has e.g. sections that start after the 4GiB boundary, they can't be represented in memory. Practically speaking, this is not causing problems, but has prevented a working elfhack for aarch64 because e.g. some relocation types don't fit in the 32-bits ELF representation. Differential Revision: https://phabricator.services.mozilla.com/D134745 commit 523b155 Author: Mike Hommey <mh+mozilla@glandium.org> Date: Thu Dec 30 20:52:55 2021 +0000 Bug 1747783 - Add support for aarch64 to elfhack. r=gsvelto Differential Revision: https://phabricator.services.mozilla.com/D134764
The elf-hack decreases the binary size and reduces start-up time.
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the upstream patches to allow elf-hack support on aarch64 (thanks @krnlyng for identifying them), and enables elf-hack to run for all Sailfish architectures.