[sailfishos][embedlite] Clean background gradients from input elements. Fixes JB#58457 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Fixes JB#58457 This covers textarea, input, select, and button.
rainemak
changed the title
llewelld
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Works nicely.
For me, the default text and border of the buttons etc. is rather thin, making them harder to notice now they're no longer embossed (previously they stood out due to the backgrounds). So maybe there's an argument for using stronger lines or font.
But that's a separate discussion as this is already a nice improvement.
|
A before/after preview, since I had one to hand.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers textarea, input, select, and button.
Instructions regarding omni debugging helps when testing this.