[sailfishos][embedlite] Revert back white default background colors. Fixes JB#59906 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fixes JB#59906 Signed-off-by: Raine Makelainen <raine.makelainen@jolla.com>
rainemak
commented
Jan 18, 2023
llewelld
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
I didn't notice any obvious changes to radio buttons or checkboxes, but text input fields without background colour set now default to a white background, and this fixes the visibility issue on https://www.swissmilk.ch/fr/recettes-idees/ . So very nice, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts back default white background color for elements that used to have white background color https://github.com/sailfishos/gecko-dev/pull/148/files
Signed-off-by: Raine Makelainen raine.makelainen@jolla.com