Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glib2] Update to version 2.78.4. JB#61330 #3

Merged
merged 1 commit into from Feb 19, 2024
Merged

[glib2] Update to version 2.78.4. JB#61330 #3

merged 1 commit into from Feb 19, 2024

Conversation

mlehtima
Copy link
Contributor

Requires integration of https://github.com/sailfishos/pcre2

@attah
Copy link

attah commented Jan 2, 2024

Please consider sneaking in a BuildRequires: ccache

@pvuorela
Copy link
Contributor

pvuorela commented Jan 4, 2024

Please consider sneaking in a BuildRequires: ccache

Why?

@attah
Copy link

attah commented Jan 4, 2024

Because it is seems to be the case; i.e. wouldn't build with a clean-ish sfdk for me.
Other environments seems to have it somewhat by default, or left over since a previous package build, like i had: sailfishos/glib-networking#2 (comment)

@pvuorela
Copy link
Contributor

pvuorela commented Jan 4, 2024

Because it is seems to be the case; i.e. wouldn't build with a clean-ish sfdk for me.

I don't think there's anything really here depending on it. I recall some meson related ccache detection problem leading to failures, but sprinkling the ccache dependency around would feel like papering over it. Should work if it's manually installed, I'd assume.

@attah
Copy link

attah commented Jan 5, 2024

You seem to be correct in that meson detects e.g.
``C++ compiler for the host machine: ccache c++ (gcc 8.3.0 "aarch64-meego-linux-gnu-c++ (Linaro GCC 8.2-2018.08~dev) 8.3.0 20190222 (Sailfish OS gcc 8.3.0-7)")

...but then ccache isn't actually available.
And indeed it seems optional: https://mesonbuild.com/Feature-autodetection.html

@attah
Copy link

attah commented Jan 5, 2024

Newer meson seems to have a related improvement; but it didn't help.... and i still think we are surviving on that other packages have installed ccache before and/or it being generally available.

@mlehtima
Copy link
Contributor Author

mlehtima commented Jan 5, 2024

Probably would make sense to have ccache installed in sdk targets or tooling (which ever is correct place for it) by default.

@pvuorela
Copy link
Contributor

pvuorela commented Jan 6, 2024

Probably would make sense to have ccache installed in sdk targets or tooling (which ever is correct place for it) by default.

Indeed if not fixing the real problem, this would be a nicely isolated workaround. One place instead of here and there.

For the bug itself, I'm not sure is it even a meson bug or something towards sb2.

@pvuorela
Copy link
Contributor

Maybe everyone noticed, but for reference the ccache issue fixed there sailfishos/scratchbox2#24

@mlehtima mlehtima changed the title [glib2] Update to version 2.78.3. JB#61330 [glib2] Update to version 2.78.4. JB#61330 Jan 23, 2024
@pvuorela
Copy link
Contributor

Still good

@mlehtima mlehtima merged commit a05a96a into master Feb 19, 2024
@mlehtima mlehtima deleted the jb61330 branch February 19, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants