Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom is actually a float value, don't convert to int #80

Merged
merged 1 commit into from Mar 22, 2024

Conversation

simonschmeisser
Copy link
Contributor

While looking at sailfishos/droidmedia#123 @b100dian noticed that my PR is superflous as this will actually be truncated here.

Functionality wise I still see steps in the zoom with the camera2 branch, will now cross verify with camera1

@simonschmeisser
Copy link
Contributor Author

For camera1 api the zoom steps are much larger (44 vs 8.0) so this is not as noticeable

@b100dian
Copy link

That is a very good explanation 44 steps vs 8 (or 4 in my case)

@mlehtima mlehtima merged commit 2851151 into sailfishos:master Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants