From 0b67b81608a4f3aa8180090c70dbbd0ab6deea20 Mon Sep 17 00:00:00 2001
From: Simon Schmeisser <simon.schmeisser@optonic.com>
Date: Sun, 11 Feb 2024 18:56:58 +0100
Subject: [PATCH] zoom is actually a float value, don't convert to int

---
 gst/droidcamsrc/gstdroidcamsrcphotography.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/gst/droidcamsrc/gstdroidcamsrcphotography.c b/gst/droidcamsrc/gstdroidcamsrcphotography.c
index 0e217976..f56d0dd6 100644
--- a/gst/droidcamsrc/gstdroidcamsrcphotography.c
+++ b/gst/droidcamsrc/gstdroidcamsrcphotography.c
@@ -1321,7 +1321,6 @@ gst_droidcamsrc_set_flash_mode (GstDroidCamSrc
 static gboolean
 gst_droidcamsrc_set_zoom (GstDroidCamSrc * src, gfloat zoom)
 {
-  int step = zoom;
   int max_zoom;
   gboolean ret;
   gchar *value;
@@ -1330,9 +1329,9 @@ gst_droidcamsrc_set_zoom (GstDroidCamSrc * src, gfloat zoom)
   max_zoom = src->max_zoom;
   GST_OBJECT_UNLOCK (src);
 
-  if (step > max_zoom) {
-    GST_WARNING_OBJECT (src, "requested zoom (%d) is larger than max zoom (%d)",
-        step, max_zoom);
+  if (zoom > max_zoom) {
+    GST_WARNING_OBJECT (src, "requested zoom (%f) is larger than max zoom (%d)",
+        zoom, max_zoom);
     return FALSE;
   }
 
@@ -1340,8 +1339,7 @@ gst_droidcamsrc_set_zoom (GstDroidCamSrc * src, gfloat zoom)
   src->photo->settings.zoom = zoom;
   GST_OBJECT_UNLOCK (src);
 
-  step -= 1;
-  value = g_strdup_printf ("%d", step);
+  value = g_strdup_printf ("%f", zoom);
   ret = gst_droidcamsrc_set_and_apply (src, "zoom", value);
 
   GST_DEBUG_OBJECT (src, "zoom set to %s", value);