Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gstreamer] Split libgstcheck to its own package. JB#57519 #2

Merged
merged 1 commit into from Apr 1, 2022

Conversation

pvuorela
Copy link
Contributor

@pvuorela pvuorela commented Apr 1, 2022

Packages needing the library shouldn't need to pull in bunch of -devel
things.

@spiiroin @abranson @mlehtima

@mlehtima
Copy link
Contributor

mlehtima commented Apr 1, 2022

Just noting that in Fedora packaging the libgstcheck*.so.* is in the main gstreamer package and the .so in devel package

@pvuorela
Copy link
Contributor Author

pvuorela commented Apr 1, 2022

Yea, though the library seems to be needed quite rarely and we have more limited space so ended up doing this subpackage.

@Thaodan
Copy link

Thaodan commented Apr 1, 2022

Yea, though the library seems to be needed quite rarely and we have more limited space so ended up doing this subpackage.

If the main .so is still in the -devel package isn't the new subpackage always pulled in?

@spiiroin
Copy link

spiiroin commented Apr 1, 2022

If the main .so is still in the -devel package isn't the new subpackage always pulled in?

xxx.so = symlink that is used/needed only during build+link -> in devel package
xxx.so.* = soname symlinks / actual libary file are needed during runtime -> in non-devel packages

Having all "%{_libdir}/libgstcheck-%{majorminor}.so*" files in devel-package is odd, because then anything built against that library requires having the devel packages installed on device before it can be executed.

So, changes make sense to me, just wondering whether the new package should be called "libgstcheck" rather than just "gstcheck".

@Thaodan
Copy link

Thaodan commented Apr 1, 2022

If the main .so is still in the -devel package isn't the new subpackage always pulled in?

xxx.so = symlink that is used/needed only during build+link -> in devel package

I know but if package doesn't need the libgstest but gstreamer-devel the libgstest still be installed in to the builder.

@pvuorela
Copy link
Contributor Author

pvuorela commented Apr 1, 2022

I know but if package doesn't need the libgstest but gstreamer-devel the libgstest still be installed in to the builder.

Yea that should happen and just realized I was missing dependency, -devel should pull in the gstcheck.

@pvuorela
Copy link
Contributor Author

pvuorela commented Apr 1, 2022

So, changes make sense to me, just wondering whether the new package should be called "libgstcheck" rather than just "gstcheck".

Hm, perhaps that could be slightly better.

Packages needing the library shouldn't need to pull in bunch of -devel
things.
@spiiroin
Copy link

spiiroin commented Apr 1, 2022

I know but if package doesn't need the libgstest but gstreamer-devel the libgstest still be installed in to the builder.

Mmm, yes. That way. One could of course have separate gsttest-devel. But that would be rather small build time improvement at the cost of needing dependency changes in those packages that actually need gsttest library. Maybe not worth the effort?

@pvuorela
Copy link
Contributor Author

pvuorela commented Apr 1, 2022

Maybe not worth the effort?

Not worth it indeed.

@pvuorela pvuorela merged commit edcc803 into master Apr 1, 2022
@mlehtima mlehtima deleted the gstcheck_package branch February 4, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants