Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.2.0 #2

Merged
merged 1 commit into from Aug 10, 2022
Merged

Update to 3.2.0 #2

merged 1 commit into from Aug 10, 2022

Conversation

nephros
Copy link

@nephros nephros commented May 12, 2022

Current version 3.0.2 is getting old-ish.

This PR proposes a version bump.

Upstream currently has three newer candidates available: 3.0.5, 3.1.2, and 3.2.0.

The branch this PR is based from contains the history of updating to each of those.

The fork also has the branches htop-3.0, and htop-3.1 which have history of updating to the latest minor-minor of that version only.
Each of the branches has a tag for easy building and merging.

This should allow for the most conservative update you deem useful.

I have done basic testing for each of them under SFOS 4.2 on arm(32), all appear to work fine.

There are builds for testing available at:

@mlehtima
Copy link
Contributor

I think we should update directly to 3.2.0. Could you rebase the patches in the repo, for example the proper-icon-location.patch already reports some fuzz when applied and also all have some offsets so it would be nice if all patches applied without any warnings. Also squash all commits into one commit and use commit message format "[htop] Update to 3.2.0".

 - bump version to 3.2.0
 - package svg icon
 - rebase all patches
@nephros
Copy link
Author

nephros commented May 13, 2022

I think we should update directly to 3.2.0. Could you rebase the patches in the repo, [...] Also squash all commits into one commit and use commit message format "[htop] Update to 3.2.0".

Here you go :)

@Thaodan Thaodan changed the title Update to recent version Update to 3.2.0 May 16, 2022
Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pvuorela pvuorela merged commit cfa36de into sailfishos:master Aug 10, 2022
@direc85
Copy link

direc85 commented Aug 20, 2022

Tested 3.2.0 on my Xperia 10 III - self-built, because the links don't work at the time of writing - and it works fine. It can also report CPU core frequencies, which didn't work on 3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants