find-mmc-bypartlabel: test for cases where the disk is on mmcblk1 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if that's the right change because this could break in case of race conditions. |
[find-mmc-bypartlabel] Test for cases where the disk is on mmcblk1. Contributes to JB#58522. Few devices have internal storage labeled by kernel as mmcblk1. Adding it to search path may allow for SD card boot in some rare cases, however it should not happen if internal storage is functioning and has required partition as it is checked first.
NotKit
changed the title
|
It should be quite unlikely to suffer from race conditions as on devices with mmcblk0 the internal storage gets detected first every time (hence numbered as 0), so you can't get mmcblk1 to appear earlier than mmcblk0. |
|
Tested on Jolla C with sd-card (both mmcblk0 and mmcblk1 present) |
mkosola
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few devices have internal storage labeled by kernel as mmcblk1. Adding it to search path may allow for SD card boot in some rare cases, however it should not happen if internal storage is functioning and has required partition as it is checked first.