WIP: [tests] Fix EventModelTest::testContactMatching(). Fixes JB#57536 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7536 Also made the common.cpp removal a bit more stricter as the id should be in both changeWaits and changeRecords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of the contact ids after they are no longer used seems to fix
the issue of some of them not being in the changeRecords but still
visible to the events. In many cases there is a long timeout wait when
the removal fails and the changeRecords does not hold the entry.
Also made the common.cpp removal a bit more stricter as the id should be
in both changeWaits and changeRecords.