[libconnman-qt] Fix NetworkTechnology objects removal #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before NetworkManager::technologyRemoved is called there is NetworkTechnology::technologyRemoved which destroys interface (delete m_technology) so objPath() returns QString(). This leads to memory leak and flood of dbus GetProperties messages increasing on every technology add/remove.
|
@pvuorela @LaakkonenJussi can you take a look at this? |
llewelld
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
This is a nice find. I wasn't able to test the failing case, but the code change looks sensible to me.
I tried to think of ways that objPath() might differ from path(), but struggled to find any other than in this particular case. The situation where an empty path is set seems to be a special case, but not one that this change affects. So this LGTM.
LaakkonenJussi
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before NetworkManager::technologyRemoved is called there is NetworkTechnology::technologyRemoved which destroys interface (delete m_technology) so objPath() returns QString(). This leads to memory leak and flood of dbus GetProperties messages increasing on every technology add/remove.