[libconnman-qt] Clarify getTechnology() API dangers. JB#59734 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlehtima
approved these changes
Jan 2, 2023
|
Then realized that of course the instances are parented so qml doesn't mess up with those. But on Sailfish this is practically unused so maybe cleaner if we get rid of this way of creating technology instances. |
LaakkonenJussi
approved these changes
Jan 9, 2023
pvuorela
force-pushed
the
qml_technology_api
branch
from
0b82ecd
to
6deb9bd
Compare
pvuorela
changed the title
pvuorela
changed the title
mlehtima
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less unused API for which the implementation didn't specify ownership to c++. Then with both qml and c++ deleting content without telling others it's been a problem just waiting to arise.
Instead providing now a simpler hasTechnology(string).
The NetworkTechnology can be instantiated also directly, which is the common usage.
@mlehtima @LaakkonenJussi