Follow DefaultRoute signal, use ordered list in checking default route. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires sailfishos/connman#46 |
mlehtima
reviewed
Jun 13, 2023
LaakkonenJussi
force-pushed
the
jb58240
branch
2 times, most recently
from
51ab6a5
to
fb04f8c
Compare
LaakkonenJussi
changed the title
rainemak
reviewed
Aug 9, 2023
rainemak
reviewed
Aug 9, 2023
mlehtima
reviewed
Jan 8, 2024
LaakkonenJussi
force-pushed
the
jb58240
branch
from
d90b034
to
7b69b7e
Compare
mlehtima
approved these changes
Jan 19, 2024
LaakkonenJussi
force-pushed
the
jb58240
branch
from
7b69b7e
to
fad342c
Compare
…8240 ConnMan sends additional PropertyChanged signal that indicates to which defaultroute has been changed to. Use this to see changes in the service, which includes changes to VPN being the default route. Improve default route management by using ordered list to check for default route. If the topmost service is connected it is used as a default route because ConnMan reports the list of services in ordered manner and the top one is the default route. No need to parse routing tables for the default route. This change accounts for VPNs being as default and the next one in the list is ordered to be the transport service used by the VPN. As VPN services are not included in networkmanager use the next connected as the default and keep network in connected state.
…#58240 Do the default route update always when the VPN used as default route disconnects. This ensures that the update will reach the apps in such case as well.
LaakkonenJussi
force-pushed
the
jb58240
branch
from
fad342c
to
a43ccbe
Compare
LaakkonenJussi
changed the title
ConnMan 1.32+git208 will have the DefaultRoute signal sent. The whole operation after the previous two commits is changed to rely on that signal. Set requirement to that ConnMan version.
mlehtima
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitor the DefaultRoute PropertyChanged signal and use ordered list for checking default route in order to improve default route management. This information contains also VPNs that are not supported by networkmanager and in such case the next connected from the ordered list is selected as "default" which is effectively the transport. This is to keep the upper layers informed that the network is still connected.