Add support for NetworkService::MoveBefore/After

[iceaway]

Hello. I noted that he MoveBefore/MoveAfter methods were not implemented so I gave it a go.

[pvuorela]

One comment but guess this should be generally fine.

cc @LaakkonenJussi

[iceaway]

One comment but guess this should be generally fine.

cc @LaakkonenJussi

Well spotted! I updated the PR with that change.

[pvuorela]

No wait, this doesn't compile:

networkservice.cpp:336:49: error: no matching function for call to ‘NetworkService::Private::InterfaceProxy::asyncCall(const char [11], const QDBusObjectPath&)’
{ return asyncCall("MoveBefore", service); }

Could also squash the commits into one.

[LaakkonenJussi]

No wait, this doesn't compile:

networkservice.cpp:336:49: error: no matching function for call to ‘NetworkService::Private::InterfaceProxy::asyncCall(const char [11], const QDBusObjectPath&)’ { return asyncCall("MoveBefore", service); }

Could also squash the commits into one.

And shouldn't these new functions be also defined in plugin/plugins.qmltypes ?

[pvuorela]

And shouldn't these new functions be also defined in plugin/plugins.qmltypes ?

We haven't bothered with those during development. Changes updated with tooling going through all the projects when getting close doing an os release.

[iceaway]

No wait, this doesn't compile:

networkservice.cpp:336:49: error: no matching function for call to ‘NetworkService::Private::InterfaceProxy::asyncCall(const char [11], const QDBusObjectPath&)’ { return asyncCall("MoveBefore", service); }

Could also squash the commits into one.

That's strange. On my machine it compiles without any errors using this command:

$ qmake && make -j

[pvuorela]

That's strange. On my machine it compiles without any errors using this command:

What's the build environment and qt version? I'm guessing it might be some relatively new.
On 5.14 there's QDBusObjectPath::operator QVariant() added.

On our 5.6 I get this compiling by using QVariant::fromValue(service)) as parameter. Disclaimer: didn't confirm the D-Bus call gets done with the proper signature.

[iceaway]

What's the build environment and qt version? I'm guessing it might be some relatively new. On 5.14 there's QDBusObjectPath::operator QVariant() added.

I'm using 5.15 here.

On our 5.6 I get this compiling by using QVariant::fromValue(service)) as parameter. Disclaimer: didn't confirm the D-Bus call gets done with the proper signature.

I updated my code to use this instead and can confirm that it works on my system.

[pvuorela]

Better now. Thanks.

[pvuorela]

Sorry again. Being about to merge and got one more 'wait a minute'.

So the API here uses QDBusObjectPath on the methods while the 'path' property and the NetworkService ctor use QString as type. I think it would be nice having the actual d-bus details under the hood, not leaking externally on the headers, and thus use also QString for the services here. Would also work better if exposing the functionality to QML.

[iceaway]

Sorry again. Being about to merge and got one more 'wait a minute'.

So the API here uses QDBusObjectPath on the methods while the 'path' property and the NetworkService ctor use QString as type. I think it would be nice having the actual d-bus details under the hood, not leaking externally on the headers, and thus use also QString for the services here. Would also work better if exposing the functionality to QML.

No worries! Better to get it right :)

Do you mean something like this:

void NetworkService::moveAfter(const QString &service)
{
    if (m_priv->m_proxy) {
        m_priv->m_proxy->MoveAfter(QDBusObjectPath(service));
    }
}

[pvuorela]

Do you mean something like this:

Yea.

[iceaway]

Yea.

Great, updated and tested.

[pvuorela]

Looking good and hopefully this time for real :D