Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files
[libcontact] Fix recursive resolve never finishing. Contributes to JB…
…#42702

ResolveListener::addressResolved() implementations can do silly things
like start resolving for something it just received information for.
That ended up new request being filtered out as duplicate request
but then never getting response with addressResolved.

Above case with libcommhistory / RecentContactsModel.
  • Loading branch information
pvuorela committed Aug 30, 2018
1 parent 96361fd commit 84b004f0231102e06b5fc69c2ae624c48962cb54
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/seasidecache.cpp
@@ -2909,9 +2909,9 @@ void SeasideCache::addressRequestStateChanged(QContactAbstractRequest::State sta

m_unknownAddresses.append(data);
}
m_pendingResolve.remove(data);
data.listener->addressResolved(data.first, data.second, item);
delete it.key();
m_pendingResolve.remove(data);
m_resolveAddresses.erase(it);
}

0 comments on commit 84b004f

Please sign in to comment.