This repository has been archived by the owner. It is now read-only.
Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[libcontacts] make sure UpdateRequest processing continues
The logic for scheduling UpdateRequest events broke down when m_contactsToAppend went empty during a fetch request; even though more contacts were coming in through contactsAvailable, no more UpdateRequest events would be scheduled until the whole request was complete. Fixed by making m_updatesPending the definitive flag for whether there is an UpdateRequest event on the queue, rather than leaving it on during the whole fetch request. This change is safe because the flag was only inspected by the requestUpdate() helper and had no side meanings. Now all UpdateRequest event scheduling goes through requestUpdate().
- Loading branch information