Skip to content
This repository has been archived by the owner. It is now read-only.
Browse files
[libcontacts] make sure UpdateRequest processing continues
The logic for scheduling UpdateRequest events broke down when
m_contactsToAppend went empty during a fetch request; even though
more contacts were coming in through contactsAvailable, no more
UpdateRequest events would be scheduled until the whole request
was complete.

Fixed by making m_updatesPending the definitive flag for whether
there is an UpdateRequest event on the queue, rather than leaving
it on during the whole fetch request.

This change is safe because the flag was only inspected by the
requestUpdate() helper and had no side meanings. Now all
UpdateRequest event scheduling goes through requestUpdate().
  • Loading branch information
amtep committed Sep 12, 2014
1 parent 1707297 commit ff84e74fefdebb9d2c2c25e63a8ef08de9757581
Showing with 4 additions and 5 deletions.
  1. +4 −5 src/seasidecache.cpp
@@ -1751,6 +1751,7 @@ bool SeasideCache::event(QEvent *event)
if (event->type() != QEvent::UpdateRequest)
return QObject::event(event);

m_updatesPending = false;
bool idleProcessing = false;

@@ -1766,14 +1767,11 @@ bool SeasideCache::event(QEvent *event)

// Send another event to trigger further processing
QCoreApplication::postEvent(this, new QEvent(QEvent::UpdateRequest));
return true;

if (idleProcessing) {
// We have nothing pending to do
m_updatesPending = false;

// Remove expired contacts when all other activity has been processed
if (!m_expiredContacts.isEmpty()) {
QList<quint32> removeIds;
@@ -2217,6 +2215,7 @@ void SeasideCache::contactsAvailable()
} else {
m_contactsToAppend.insert(type, qMakePair(queryDetailTypes, contacts));
} else {
if (m_activeResolve || (request == &m_fetchByIdRequest)) {
// Process these results immediately
@@ -2704,7 +2703,7 @@ void SeasideCache::requestStateChanged(QContactAbstractRequest::State state)

// See if there are any more requests to dispatch
QCoreApplication::postEvent(this, new QEvent(QEvent::UpdateRequest));

void SeasideCache::makePopulated(FilterType filter)

0 comments on commit ff84e74

Please sign in to comment.