Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libjpeg-turbo] enable jpeg_mem_src/dest #1

Merged
merged 1 commit into from Sep 2, 2022

Conversation

attah
Copy link
Contributor

@attah attah commented Aug 26, 2022

You'll need this for any significant update to Poppler (21.12.0 and onwards).
Sure, this is a bit iffy library-versioning-wise, but i can't see that it actually breaks anything and all the cool kids are doing it.
But then again, C/C++ is not my day job.

Copy link

@Thaodan Thaodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain the change better and rather implicitly enabling it, enable it explicitly.

This way it is reproducible and it breaks once the option is removed.

@attah
Copy link
Contributor Author

attah commented Aug 26, 2022

What this does is make the source/destination managers (i.e. io handlers) that work with in-memory data exist at all, along side with the previous only option that handles FILE*.

See also: https://github.com/sailfishos-mirror/libjpeg-turbo/blob/a219fd13b086d9af53de37a5e1bfec985cda60fc/README.md#in-memory-sourcedestination-managers

I'm not sure i follow, there is nothing that will break if a define no longer does anything or exists inside the code, so -DWITH_MEM_SRCDST=1 would be pointless.

@Thaodan
Copy link

Thaodan commented Aug 26, 2022

What this does is make the source/destination managers (i.e. io handlers) that work with in-memory data exist at all, along side with the previous only option that handles FILE*.

Ok that sounds good, as the api isn't harbour whitelist abi breaks shouldn't matter, if we decide to preserve in abi in this case need to offer both versions.

I'm not sure i follow, there is nothing that will break if a define no longer does anything or exists inside the code, so -DWITH_MEM_SRCDST=1 would be pointless.

Other build systems usually exit if you specific invalid options, e.g if upstream removes or renames it something happen.
But I get it now.

@pvuorela
Copy link
Contributor

Needs now rebasing.

Otherwise seems good to me. Since nothing promised for this library, better to avoid sticking to old ABI.

@pvuorela pvuorela merged commit cdadcfc into sailfishos:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants