Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mce-qt] Add support for chargering control state tracking. JB#58812 #1

Merged
merged 1 commit into from Oct 11, 2022

Conversation

spiiroin
Copy link
Contributor

Required constants are defined in mce-dev >= 1.30.0

The D-Bus methods and signals are available in mce >= 1.110.0

Signed-off-by: Simo Piiroinen simo.piiroinen@jolla.com

Copy link
Member

@monich monich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/src/qmcechargingstate.cpp Outdated Show resolved Hide resolved
Copy link
Member

@martyone martyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright notice needs to be fixed I think, otherwise LGTM.

@rainemak
Copy link
Member

The copyright notice needs to be fixed I think, otherwise LGTM.

Copyright with time span is good as well. Only @monich and @spiiroin contributions there. Approved.

Required constants are defined in mce-dev >= 1.30.0

The D-Bus methods and signals are available in mce >= 1.110.0

Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
@spiiroin
Copy link
Contributor Author

Did a quick smoketest on target device - still seems to work.
Review commits squashed.

@spiiroin spiiroin merged commit 77b9d90 into sailfishos:master Oct 11, 2022
@spiiroin spiiroin deleted the jb58812_charging_disabled branch October 11, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants