[libngf-qt] Make multiple state changes more robust. JB#61050 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If calling e.g. stop() twice both of those request were passed to ngfd which at later moment didn't anymore have the event with such id, got confused and issued warnings. Some details adjusted: - State change method bool return values are defined as "False if no connection to NGF daemon", so making them behave as such. Though didn't find any place interested in the return values. - Some methods renamed a bit to match better what they do, e.g. set or request something. - Splitted the pending state change requested to its own member variable to keep it simpler. Active state is now what's reported active by the server and wanted state is what's requested the last time from the server, protecting against requesting same thing many times.
mlehtima
approved these changes
Nov 30, 2023
spiiroin
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If calling e.g. stop() twice both of those request were passed to ngfd which at later moment didn't anymore have the event with such id, got confused and issued warnings.
Some details adjusted: