New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-module-prefix option #12
Conversation
|
One thing btw worrying me with these sed placeholders is the 'make qmltypes' build target which regenerates the file. That problem should be avoidable with just renaming the api but providing the backward compatibility links (e.g. like that nemo-dbus). |
|
I wouldn't mind to drop this |
qmlplugindump is deprecated as of 6.2.0 as per https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.2.0/release-note.md |
|
That would work for me too. Just not sure how to do that? Can register with both names simply? |
|
That would work for me too. Just not sure how to do that? Can register with
both names simply?
That's how it was done for the other modules.
|
Intesresting. However we are not going to get 6.2.0 any time soon here.
Like this. Can do that on the .spec and just rename the module elsewhere, or then do the same things in the .pro file side. |
Like this one I guess? https://github.com/sailfishos/nemo-qml-plugin-dbus/blob/master/src/plugin/plugin.cpp#L42 |
We don't use .spec here but Yocto, but can do something similar there. |
Yes, that's what I meant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Allow building module without prefix similar to: sailfishos/libconnman-qt@625beb2 Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
7ec57df
to
85d01f0
Compare
|
@monich done :) |
Allow building module without prefix similar to: sailfishos/libconnman-qt@625beb2
Signed-off-by: Herman van Hazendonk github.com@herrie.org