Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-module-prefix option #12

Merged
merged 1 commit into from Jun 15, 2022
Merged

Conversation

Herrie82
Copy link
Contributor

Allow building module without prefix similar to: sailfishos/libconnman-qt@625beb2

Signed-off-by: Herman van Hazendonk github.com@herrie.org

@pvuorela
Copy link
Contributor

One thing btw worrying me with these sed placeholders is the 'make qmltypes' build target which regenerates the file. That problem should be avoidable with just renaming the api but providing the backward compatibility links (e.g. like that nemo-dbus).

@monich
Copy link
Member

monich commented Jun 14, 2022

I wouldn't mind to drop this USE_MODULE_PREFIX thing and allow both "MeeGo.QOfono" and "QOfono" in QOfonoDeclarativePlugin::registerTypes

@Herrie82
Copy link
Contributor Author

One thing btw worrying me with these sed placeholders is the 'make qmltypes' build target which regenerates the file. That problem should be avoidable with just renaming the api but providing the backward compatibility links (e.g. like that nemo-dbus).

qmlplugindump is deprecated as of 6.2.0 as per https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.2.0/release-note.md

@Herrie82
Copy link
Contributor Author

That would work for me too. Just not sure how to do that? Can register with both names simply?

@Thaodan
Copy link

Thaodan commented Jun 14, 2022 via email

@pvuorela
Copy link
Contributor

qmlplugindump is deprecated as of 6.2.0 as per https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.2.0/release-note.md

Intesresting. However we are not going to get 6.2.0 any time soon here.

That would work for me too. Just not sure how to do that? Can register with both names simply?

Like this.
https://github.com/sailfishos/nemo-qml-plugin-dbus/blob/master/rpm/nemo-qml-plugin-dbus-qt5.spec#L56

Can do that on the .spec and just rename the module elsewhere, or then do the same things in the .pro file side.

@Herrie82
Copy link
Contributor Author

That would work for me too. Just not sure how to do that? Can register with both names simply?
That's how it was done for the other modules.

Like this one I guess? https://github.com/sailfishos/nemo-qml-plugin-dbus/blob/master/src/plugin/plugin.cpp#L42

@Herrie82
Copy link
Contributor Author

qmlplugindump is deprecated as of 6.2.0 as per https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.2.0/release-note.md

Intesresting. However we are not going to get 6.2.0 any time soon here.

That would work for me too. Just not sure how to do that? Can register with both names simply?

Like this. https://github.com/sailfishos/nemo-qml-plugin-dbus/blob/master/rpm/nemo-qml-plugin-dbus-qt5.spec#L56

Can do that on the .spec and just rename the module elsewhere, or then do the same things in the .pro file side.

We don't use .spec here but Yocto, but can do something similar there.

@monich
Copy link
Member

monich commented Jun 14, 2022

That would work for me too. Just not sure how to do that? Can register with both names simply?
That's how it was done for the other modules.

Like this one I guess? https://github.com/sailfishos/nemo-qml-plugin-dbus/blob/master/src/plugin/plugin.cpp#L42

Yes, that's what I meant.

@Herrie82
Copy link
Contributor Author

Herrie82 commented Jun 14, 2022

@monich I pushed 7ec57df happy to squash

Copy link
Member

@monich monich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monich
Copy link
Member

monich commented Jun 15, 2022

@monich I pushed 7ec57df happy to squash

Please do

Allow building module without prefix similar to: sailfishos/libconnman-qt@625beb2

Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
@Herrie82
Copy link
Contributor Author

@monich done :)

@rainemak rainemak merged commit 4d230bc into sailfishos:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants