Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the qml.path variable must contain only directory not filename #15

Merged
merged 1 commit into from Dec 21, 2022

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Dec 15, 2022

otherwise is file installed into /opt/examples/libqofono-qt5/qml/ofonotest/main.qml/main.qml (at least with Qt 5.15.7) and example application simply doesn't work

Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but could you still adjust the commit message a bit to the common format. First a title line, then an empty line and then finally the description, and line length limited to 80 characters.

Previously, the main.qml was installed as /opt/examples/libqofono-qt5/qml/ofonotest/main.qml/main.qml
@jmlich
Copy link
Contributor Author

jmlich commented Dec 21, 2022

I hope that now it is better

@pvuorela
Copy link
Contributor

The line on the description part is now 102 characters, but that's already a lot better than the previous single extra long line, and good enough for me now. Thanks.

@pvuorela pvuorela merged commit a199b13 into sailfishos:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants