Non-initialized .modems breaks example app #17
Conversation
|
Please rebase instead of having a merge commit. |
ofonotest/qml/ofonotest/main.qml
Outdated
| MouseArea { | ||
| anchors.fill: parent | ||
| onClicked: { | ||
| context1.active = !context1.active | ||
| context1.active = !context1.active; |
There was a problem hiding this comment.
We don't use semicolons at the end of the lines.
There was a problem hiding this comment.
I will remove that. The semicolon was probably added by qmlformat.
ofonotest/qml/ofonotest/main.qml
Outdated
| textLine2.text = manager.available ? netreg.currentOperator["Name"].toString() :"Ofono not available" | ||
| console.log("Ofono is " + available); | ||
| console.log("netreg.currentOperatorPath: " + netreg.currentOperatorPath); | ||
| textLine2.text = (manager.available && netreg.currentOperator !== undefined) ? netreg.currentOperator["Name"].toString() : "Ofono not available"; |
There was a problem hiding this comment.
Hm, maybe not regression but trying this I'm getting console output of
[D] onAvailableChanged:55 - Ofono is true
and this saying "Ofono not available" on the UI. Supposedly because of:
[D] onAvailableChanged:56 - netreg.currentOperatorPath:
There was a problem hiding this comment.
Actually, I am not sure what was original purpose. I can guess that it should write mobile operator name, but the value is accessible via netreg.name. The array seems to be not populated. I didn't check how this interface changed in the past.
There was a problem hiding this comment.
Personally, I would avoid assignment textLine2.text = , because it breaks binding defined above (I have changed the behaviour in recent force push in this merge request). As result it is showing network operator now (KAKTUS in my case, but can be T-Mobile or AT&T as well)
ofonotest/qml/ofonotest/main.qml
Outdated
| // console.log("modem1.name " + modem1.name) | ||
| // console.log("modem1.model " + modem1.model) | ||
| console.log("modem1.manufacturer " + modem1.manufacturer); | ||
| console.log("modem1.features " + modem1.features); |
There was a problem hiding this comment.
These could have colon. Now I'm getting output of just "modem1.manufacturer" which is a bit strange.
There was a problem hiding this comment.
These still apply.
For another thing the line ending semicolon is also here and on multiple other places.
There was a problem hiding this comment.
I prefer to use semicolons explicitly because of javascript have some evil cases when it joins multiple lines into one expression. If I understand correctly, you have some guideline to avoid them if possible, so I removed them.
|
Some small comments. Shouldn't be related to this PR but executing the test app binary I'm getting console output but no window. Running qmlscene with the main qml file shows the window too. Interesting. |
jmlich
force-pushed
the
master
branch
3 times, most recently
from
f3d3ae5
to
00fe6b0
Compare
|
Actually, I was also using qmlscene, because the binary didn't worked for me either. I have expected that there is some trouble in my setup. The documentaion says: https://doc.qt.io/qt-5/qqmlapplicationengine.html
I have updated the code accordingly |
ofonotest/main.cpp
Outdated
| @@ -8,5 +9,9 @@ Q_DECL_EXPORT int main(int argc, char *argv[]) | |||
| QQmlApplicationEngine engine; | |||
| engine.load(QUrl(QLatin1String("/opt/examples/libqofono-qt5/qml/ofonotest/main.qml"))); | |||
|
|
|||
| if ( QWindow* window = qobject_cast<QWindow*>( engine.rootObjects().at(0) ) ) { | |||
There was a problem hiding this comment.
Hm, this appears to evaluate false here. rootObjects().at(0) is QQuickRectangle
There was a problem hiding this comment.
I have changed the main.qml to contain Window. In my tests the binary already shows the window, so it works for me.
There was a problem hiding this comment.
I am not sure, but the Window object is maybe enough it self without changes in C++ part. I can retest it, but not during working hours
There was a problem hiding this comment.
It must be something like:
Window {
width: 320
height: 200
visible: true
}
My recent push --force contain required changes
jmlich
force-pushed
the
master
branch
3 times, most recently
from
071cdac
to
58df79e
Compare
It seems there is an lazy initialization of ModemManager.modems as consequence, the modems[0] are not available at the time of start application and nothing works. Similar OfonoConnMan contexts are not initialized. The binding must check if array is defined and its length I have added also the SimManager check to make sure that the Pin is entered, because it prevents further testing. Also window of example application wasn't showing
It seems there is an lazy initialization of ModemManager.modems as consequence, the modems[0] are not available at the time of start application and nothing works.
Similar OfonoConnMan contexts are not initialized. The binding must check if array is defined and its length
I have added also the SimManager check to make sure that the Pin is entered, because it prevents further testing.
I am not sure about netreg.currentOperator["Name"] I keept it as is was