Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connectionmanager] Add support for reset contexts dbus call #6

Merged
merged 1 commit into from Mar 21, 2022
Merged

[connectionmanager] Add support for reset contexts dbus call #6

merged 1 commit into from Mar 21, 2022

Conversation

neochapay
Copy link
Contributor

@monich
Copy link
Member

monich commented Mar 21, 2022

Please make resetContexts() asynchronous, and if you need it to be synchronous then name it resetContextsSync() and return the result of the call, e.g.:

bool resetContextsSync(QDBusError *error = Q_NULLPTR);

@neochapay
Copy link
Contributor Author

neochapay commented Mar 21, 2022 •
edited

@monich fixed

monich
monich approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@monich monich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks acceptable

@monich monich merged commit a928774 into sailfishos:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monich monich monich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@neochapay @monich