Fix the rest of the tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ofono sends some redundant signals when modem powers down. Expect those and verify the values. Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
Adding or removing contexts is not supported on Sailfish. [1] Keep the parts that work. [1] sailfishos/ofono@19f74e6 Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
Tomin1
force-pushed
the
jb52788_fix_tests
branch
from
5e772d5
to
a18569d
Compare
pvuorela
reviewed
Mar 25, 2022
These are not supported on Sailfish any more. [1] [1] sailfishos/ofono@19f74e6 Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
Tomin1
force-pushed
the
jb52788_fix_tests
branch
from
a18569d
to
df57655
Compare
pvuorela
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sim manager tests. Ofono sends some redundant signals when modem powers down. Expect those and verify the values.
Drop context manipulation parts from connman tests. Adding or removing contexts is not supported on Sailfish. Keep the parts that work.
Expect failure on context tests on Sailfish. These are not supported on Sailfish any more.