[libsailfishapp] Requires qt5-qttools-linguist in devel. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olf0
reviewed
Feb 26, 2024
rpm/libsailfishapp.spec
Outdated
| @@ -11,6 +11,7 @@ BuildRequires: pkgconfig(Qt5Qml) | |||
| BuildRequires: pkgconfig(qdeclarative5-boostable) | |||
| BuildRequires: pkgconfig(mlite5) | |||
| BuildRequires: sailfish-qdoc-template | |||
| Requires: qt5-qttools-linguist | |||
There was a problem hiding this comment.
I wonder why this is placed here, when it should (according to the PR title and its use) be placed somewhere below line 24 "%package devel" (e.g. in line 28)?
Or is this consideration a "think'o" on my side?
There was a problem hiding this comment.
Oh, I pushed an old version and thinking that it was the wrong place, I changed it. But I forgot to save my changes before commiting. Thanks a lot for noticing.
Since the devel package is installing .prf files that depends on lupdate and lrelease, make libsailfishapp-devel requires the package that contains them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the devel package is installing .prf
files that depends on lupdate and lrelease,
make libsailfishapp-devel requires the
package that contains them.
Close #46
Related forum entry: https://forum.sailfishos.org/t/translations-not-created-in-obs/18118
This is a suggestion. Another possibility is to fix the documentation on the website.