Allow empty quoted subject #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some software encodes empty MMS subject as 2 bytes: 0x7f 0x00. That's Quote and End-of-string characters according to WSP spec: Quote = <Octet 127> End-of-string = <Octet 0> However the same section of WSP spec says this: Text-string = [Quote] *TEXT End-of-string If the first character in the TEXT is in the range of 128-255, a Quote character must precede it. Otherwise the Quote character must be omitted. The Quote is not part of the contents. Since the subject is empty, the first character in the TEXT is not in the range of 128-255 (since there's no first character), therefore the Quote character must be omitted. But it's there. Such encoding is incorrect. But let's allow it anyway.
mlehtima
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some software encodes empty MMS subject as 2 bytes:
0x7f 0x00. That'sQuoteandEnd-of-stringcharacters according to WSP spec:However the same section of WSP spec says this:
Since the subject is empty, the first character in the
TEXTis not in the range of 128-255 (since there's no first character), therefore theQuotecharacter must be omitted. But it's there. Such encoding is incorrect.But let's allow it anyway.