[libxml2] Update to 2.10.3. JB#59019 #2
Conversation
CVE-2022-23308 CVE-2022-29824 CVE-2022-2309 CVE-2022-40303 CVE-2022-40304 Removed doc and python-build subpackages. Don't seem useful since we don't build neither docs nor python support. Python-build has been there since the beginning and looks like a Fedora thing, not spotting references on sailfish.
|
|
||
| -SUBDIRS = include . doc example fuzz xstc | ||
| +SUBDIRS = include . fuzz xstc | ||
| if WITH_PYTHON |
There was a problem hiding this comment.
You don't need to patch this.
If you pass SUBDIR="include . fuzz xstc" to make it will override the default.
There was a problem hiding this comment.
I didn't change this more than rebasing the patch. SUBDIR sounds a bit arbitrary thing used externally so I'd rather not touch this now.
There was a problem hiding this comment.
SUBDIRS is the standard variable for sub makefiles in Automake projects, I've tested this with guile already overriding it over the commant line is fine.
In any case it is just a smaller suggestion that avoids the patch.
| %doc %{_docdir}/%{name}-%{version}/* | ||
| %doc %{_mandir}/man1/xml2-config.1* | ||
| %doc %{_mandir}/man3/libxml.3* | ||
| %exclude %{_libdir}/*.la |
There was a problem hiding this comment.
the *.la file should be gone without this, that should be a bug in our rpm packaging.
There was a problem hiding this comment.
What do you mean a bug? That hasn't been include in the main package earlier, the subpackage isn't afaik used by anything, and on many packages this just gets deleted.
There was a problem hiding this comment.
The rpm packaging scripts that run after the package should cleanup the *.la files.
|
|
||
| -DIST_SUBDIRS = include . doc example fuzz python xstc | ||
| +DIST_SUBDIRS = include . fuzz python xstc | ||
|
|
| -examples_DATA = xmllint.c | ||
| +#examplesdir = $(docdir)/examples | ||
| +#examples_DATA = xmllint.c | ||
|
|
There was a problem hiding this comment.
Deleting that file later would be easier I than patching I think.
|
Have you tried building python3-lxml with the updated libxml2? |
Yes, building this in feature project to make sure all good. This is already built fine. |
CVE-2022-23308 CVE-2022-29824 CVE-2022-2309 CVE-2022-40303 CVE-2022-40304
Removed doc and python-build subpackages. Don't seem useful since we don't build neither docs nor python support. Python-build has been there since the beginning and looks like a Fedora thing, not spotting references on sailfish.
@mlehtima