Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libyaml] update to 0.2.5 #1

Merged
merged 2 commits into from Jan 12, 2023
Merged

Conversation

nephros
Copy link

@nephros nephros commented Oct 18, 2022

Follow-up on sailfishos/python3-yaml#1

Now that we depend on libyaml in python3-yaml, the lib could probably benefit from a bump as well. The current version (in SFOS) is 0.1.4 from 2014 (plus some security fixes).

Is there any interest in going forward with that?

(Packages available for testing at OBS).

@pvuorela
Copy link
Contributor

Wouldn't see reasons not to update this.

What's the draft status here? Seems to be doing what it's supposed to already.

For one thing I could rearrange and squash the commits, now there are some changes back and forth. Instead first the commit for removing old sources and then all the other things in another commit.

@nephros
Copy link
Author

nephros commented Jan 11, 2023

Ok, squashed tree coming up!

nephros added 2 commits January 11, 2023 17:33
prepare for upstream git module
add upstream submodule
bootstrap autoconf
do not package vanished files
 - no html docs any more
 - readme renamed
 - license renamed
@nephros nephros marked this pull request as ready for review January 11, 2023 16:35
@nephros nephros changed the title [Draft] Version bump: 0.2.x [libyaml] update to 0.2.5 Jan 11, 2023
Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks!

@pvuorela pvuorela merged commit 2bea382 into sailfishos:master Jan 12, 2023
@@ -45,13 +45,11 @@ make check

%files
%defattr(-,root,root,-)
%doc LICENSE README
%doc License ReadMe.md
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The License file should be with %license macro. Maybe another PR about that?

@nephros nephros deleted the update-0.2 branch December 19, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants