Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Discord to androidnotificationpriorities #26

Merged
merged 1 commit into from Aug 23, 2022

Conversation

JacekJagosz
Copy link
Contributor

Discord is one of the most popular chat apps right now, this makes the notifications work as they should be.

@pvuorela
Copy link
Contributor

The explicit package overrides for android apps has been a thing we've wanted to get rid of and instead just handle good the notification properties the android apps set. With commit 3035cb8 this was some months ago restricted to the old android 4 handling used on some old devices (jolla c, xperia x) which is not getting notification improvements anymore.

I'm not totally objecting in adding this but with above in mind wondering if it's too useful anymore.

@JacekJagosz
Copy link
Contributor Author

Is that feature already exists in 4.4 and Android 10? I did that only because discord wasn't showing an icon, not making sounds and vibrating. So it seemed like adding it improved things.
If in next release this will be introduced then I agree this pull can be dropped, or maybe accepted for X users. But it is weird it seemed like this file still does something on my 10 III

@pvuorela
Copy link
Contributor

For Xperia 10 III this change will have no effect on releases after 4.4.

@JacekJagosz
Copy link
Contributor Author

So do you think this can get merged for the older devices that still make use of this file, and Discord is probably one of the most common Android apps to use?
Or should I close this pull request?

@pvuorela
Copy link
Contributor

I can merge this as the change itself looks good. I'll skip tagging and integrating fully yet as the change also shouldn't have much impact.

@pvuorela pvuorela merged commit 9fc5ee2 into sailfishos:master Aug 23, 2022
@JacekJagosz JacekJagosz deleted the patch-1 branch August 23, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants