[lipstick] Suppress charging warnings when charging is disabled. Fixes JB#58812 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyone
approved these changes
Oct 10, 2022
Yeah. IIRC way back in time there was proper signaling from bme/something that actually knows the score and we had simple event triggers notification logic at ui side. But things that came after bme did not have such feature -> lack of signaling was substituted with battery level tracking heuristics that has then over time evolved into what we have... |
…s JB#58812 When charging has been disabled for the purpose of limiting charging time and/or cycles, battery level is expected to drop while charger is connected but "Not enough power to charge" warning notifications are still triggered. Take charging enabled/disabled state into account and suppress warnings while charging is disabled. QMceChargingState is available in libmce-qt >= 1.5.0 Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb58812_charging_disabled
branch
from
74a6c4f
to
7aef62e
Compare
|
Review commits squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When charging has been disabled for the purpose of limiting charging time and/or cycles, battery level is expected to drop while charger is connected but "Not enough power to charge" warning notifications are still triggered.
Take charging enabled/disabled state into account and suppress warnings while charging is disabled.
QMceChargingState is available in libmce-qt >= 1.5.0
Signed-off-by: Simo Piiroinen simo.piiroinen@jolla.com