[lipstick] Remove connectivityMonitor from qml api. Contributes to JB#59897 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QML api doesn't appear ever used. For the rest, the vpn-updown.service seems removed from nemo-qml-plugin-systemsettings in 2018, commit 3ab5248a, JB#41460 -> the updown should have been a no-op for a while now.
pvuorela
force-pushed
the
remove_connectionmonitor_api
branch
from
b66e7ec
to
6398788
Compare
|
Actually looking more closely, seems like the whole thing is pretty much no-op these days. From the updated commit message: |
|
Couldn't build this. Took a fresh upstream repo and took this PR and used latest 64bit SDK: |
Oh wait, this happens also with master.. |
Ah, this had submodules.. |
LaakkonenJussi
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such a thing doesn't belong to homescreen services and for what I can tell it hasn't ever even be used for anything(?).
For starters just remove the context property now. Removing the rest can be handled later.