[lipstick] Do not change signal handlers on shutdown. JB#60078 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting a shutdown notification basically means that we are going to get a TERM signal in a couple of seconds. Using that as a cue for substituting TERM handler that triggers lipstick to make a clean exit with something else makes little sense. Especially as the candidates are async-signal unsafe code from hwcomposer-plugin (that can hang and require KILL) or default handler that makes quick and dirty exit (potentially leaving behind e.g. lock files). Keep using the already installed lipstick signal handlers. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
pvuorela
reviewed
Feb 6, 2023
Remove dead code, data and references in unit tests too. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
pvuorela
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting a shutdown notification basically means that we are going to get a TERM signal in a couple of seconds. Using that as a cue for substituting TERM handler that triggers lipstick to make a clean exit with something else makes little sense. Especially as the candidates are async-signal unsafe code from hwcomposer-plugin (that can hang and require KILL) or default handler that makes quick and dirty exit (potentially leaving behind e.g. lock files).
Keep using the already installed lipstick signal handlers.
Signed-off-by: Simo Piiroinen simo.piiroinen@jolla.com