[lipstick] Simplify thermal notifier. JB#60190 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiiroin
approved these changes
Feb 17, 2023
pvuorela
force-pushed
the
simplify_thermal_notifier
branch
from
eb32a24
to
6f9f2cc
Compare
This was quite much unnecessarily complicated, the thermal status getter wasn't working properly, it was a blocking d-bus call, and the whole getter was pointless when the code has been following all the state changes anyway. Also there's no point in following display state on the notifier since it's creating critical notifications which turn on the screen. The unit test was somewhat garbage too.
pvuorela
force-pushed
the
simplify_thermal_notifier
branch
from
6f9f2cc
to
0df8c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was quite much unnecessarily complicated, the thermal status getter wasn't working properly, it was a blocking d-bus call, and the whole getter was pointless when the code has been following all the state changes anyway.
Also there's no point in following display state on the notifier since it's creating critical notifications which turn on the screen.
The unit test was somewhat garbage too.
Continuation from #39