Notification text action support. JB#55557 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the type info is included, pass it on the notification.
Tomin1
reviewed
Jun 20, 2023
In case a text parameter for invokeAction on LipstickNotification is passed, there's remoteTextActionActivated on NotificationManager for the homescreen side to handle.
pvuorela
force-pushed
the
notification_text_actions
branch
from
b52cbfd
to
5008485
Compare
Tomin1
approved these changes
Jun 27, 2023
|
Getting an error elsewhere on the actionInvoked call when tapping notifications:
Might be better to make that new parameter optional, as mismatched qml calls are hard to find at build time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started here with PR #11 but the input map handling was broken, handling that properly didn't seem to go along nice and the usage on notification plugin side didn't feel entirely good. So instead moved to a simpler way with sailfishos/nemo-qml-plugin-notifications#9 . Think that should be good enough to get this moving forward now.