[lipstick] Support storing privileged source of notifications. JB#60924 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abranson
approved these changes
Dec 12, 2023
Tomin1
requested changes
Dec 12, 2023
Introducing a separate hint set for internal properties. Ensuring that they never get even by accident over D-Bus. Used that to store whether the source of the notification is a process with privileged group and to indicate that a notification action can be trusted. Notification database version schema not bumped as this didn't change any existing table.
These are already quite a mouthful and lead to problems by being unreadable.
pvuorela
force-pushed
the
privileged_notification_source
branch
from
b6bf4e9
to
5ba0b65
Compare
Tomin1
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a separate hint set for internal properties. Ensuring that they never get even by accident over D-Bus.
Used that to store whether the source of the notification is a process with privileged group and to indicate that a notification action can be trusted.
Notification database version schema not bumped as this didn't change any existing table.