New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable glib support #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of the changes should be about enabling glib support. Modifying the .spec file is a more technical detail on how it's done. The changes should be also squashed into single commit.
By the change details I'd expect you're not necessarily doing this in sailfish context? In general wouldn't want too much non-sailfish stuff on the .specs but compiling the glib shouldn't be too costly here.
Bit suspicious how well the glib stuff works in practice, though.
|
Thanks for the reply,
I'm doing that entirely for sailfish screenshot. |
6f97cd2
to
1bcc4ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the picture. Looking nice!
This PR also looking better now, only couple small details I commented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
Thanks @pvuorela! Will the change be available in the upcoming 4.6 release? |
|
Yes. |
Set enable-glib to ON in order to enable keyboard in flutter apps.
I've recompiled it locally and flutter-elinux-embedder with this patch: sony/flutter-embedded-linux@11bb961 worked well.
RPMS: maliit-framework-wayland-2.2.1.zip