Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable glib support #5

Merged
merged 1 commit into from Feb 28, 2024
Merged

Enable glib support #5

merged 1 commit into from Feb 28, 2024

Conversation

MrCyjaneK
Copy link
Contributor

@MrCyjaneK MrCyjaneK commented Feb 26, 2024

Set enable-glib to ON in order to enable keyboard in flutter apps.

I've recompiled it locally and flutter-elinux-embedder with this patch: sony/flutter-embedded-linux@11bb961 worked well.

RPMS: maliit-framework-wayland-2.2.1.zip

Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the changes should be about enabling glib support. Modifying the .spec file is a more technical detail on how it's done. The changes should be also squashed into single commit.

By the change details I'd expect you're not necessarily doing this in sailfish context? In general wouldn't want too much non-sailfish stuff on the .specs but compiling the glib shouldn't be too costly here.

Bit suspicious how well the glib stuff works in practice, though.

rpm/maliit-framework-wayland.spec Show resolved Hide resolved
rpm/maliit-framework-wayland.spec Outdated Show resolved Hide resolved
rpm/maliit-framework-wayland.spec Show resolved Hide resolved
rpm/maliit-framework-wayland.spec Outdated Show resolved Hide resolved
@MrCyjaneK MrCyjaneK changed the title Update maliit-framework-wayland.spec Enable glib support Feb 27, 2024
@MrCyjaneK
Copy link
Contributor Author

Thanks for the reply,

By the change details I'd expect you're not necessarily doing this in sailfish context? In general wouldn't want too much non-sailfish stuff on the .specs but compiling the glib shouldn't be too costly here.

I'm doing that entirely for sailfish screenshot.

Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the picture. Looking nice!

This PR also looking better now, only couple small details I commented.

rpm/maliit-framework-wayland.spec Show resolved Hide resolved
rpm/maliit-framework-wayland.spec Outdated Show resolved Hide resolved
Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pvuorela pvuorela merged commit fe4a911 into sailfishos:master Feb 28, 2024
@MrCyjaneK
Copy link
Contributor Author

Thanks @pvuorela! Will the change be available in the upcoming 4.6 release?

@pvuorela
Copy link
Contributor

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants