[charging] Add charge-once-to-full override #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes corner case testing easier. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Signed-off-by: Martin Kampas <martin.kampas@jolla.com>
martyone
approved these changes
Oct 12, 2022
Settings UI prefers charging hysteresis to be 3 percentage units wide. Align mce defaults to match this. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb58372_charging_settings
branch
from
78e30ae
to
cb4a4d9
Compare
|
Review commits squashed |
Sometimes users might have some need to charge battery to full despite normally having enabled battery ageing protection that stops charging e.g. when battery capacity reaches 80 percent. Implement "forced charging" toggle that disables battery ageing protection until battery gets fully charged, or charger is disconnected. This can then be used for implementing "Charge to full this time" type functionality in settings UI. Required constants are defined in mce-dev >= 1.31.0 Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb58372_charging_settings
branch
from
cb4a4d9
to
384a6ed
Compare
spiiroin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.