[charging] Use literal number for charging enable limit. Fixes JB#59821 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sledges
reviewed
Jan 13, 2023
Default charging enable limit shows up as zero. This is because the values are stored in stringified form and then interpreted according to expected value type and strtol() returns zero for "(90 - 3)". Switch to literal number as it used to be. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb59821_hysteresis_defaults
branch
from
aa242e0
to
76f1438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default charging enable limit shows up as zero. This is because the values are stored in stringified form and then interpreted according to expected value type and strtol() returns zero for "(90 - 3)".
Switch to literal number as it used to be.
Signed-off-by: Simo Piiroinen simo.piiroinen@jolla.com