[mce] Handle compositor startup actions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markolemmetty
approved these changes
Jan 19, 2023
markolemmetty
approved these changes
Jan 19, 2023
Querying information about D-Bus names leads those names to be queried and tracked. Debug logging can trigger this for NULL names - which then leads to problems. Explicitly check and reject NULL names from tracking. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Sometimes it is necessary to reschedule timers from within timer notify callback but wltimer implementation makes it more difficult than what it needs to be. Make it so that stop/start function calls made directly or indirectly from notification callback override stop/continue return value of the callback function. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
There are timing and permission problems with compositor handovers that cross system vs user service boundary or involve need for starting or stopping android hw compositor service. As MCE is already involved and watching over these handovers, it can also be made to perform the necessary hw compositor actions in a time frame where it ought to be safe i.e. after the previous compositor service has made an exit and the new compositor service has not yet been given permission to draw. Processes that act as compositor can implement a new dbus method call that mce can then use to query what kinds of hwc needs (stop, start, or restart) the new compositor has. If compositor does not implement this method call, mce assumes no actions ought to be taken. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb59811_compositor_actions
branch
from
b2fb4ca
to
be83ef8
Compare
|
Force push to update (c) spans |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.