New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse availability signaling and YubiKey configuration #4
Merged
spiiroin
merged 4 commits into
sailfishos:master
from
spiiroin:jb55731_mouse_availability
Oct 25, 2021
Merged
Mouse availability signaling and YubiKey configuration #4
spiiroin
merged 4 commits into
sailfishos:master
from
spiiroin:jb55731_mouse_availability
Oct 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix integer and integer vs pointer size issues. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Device names are more or less free form text, which makes them less than ideal for use as configuration entry keys. There are devices that can have multiple functions i.e. there can be several input device nodes that can't be told apart based on vendor-product information. Make it possible to define device to be configured also by using udev/modalias style bus, vendor and product id key. Make it possible to override heuristics conditionally based on probed device type i.e. configuration can be done in terms of device identification and the type mce would have arrived to by default. Add a placeholder configuration file that acts also as documentation for the feature. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
8eb34d0
to
9116708
Compare
|
I can get mouse state listening to work, but MCE_HARDWARE_MOUSE_STATE_GET method call returns an error for some reason. |
New method calls need to be made allowed-for-user and I forgot to do that. Will fix. |
spiiroin
commented
Oct 22, 2021
MCE needs to track appearing and disappearing input devices and gauge type of each input device currently available. Some of this state information is also exposed over D-Bus, e.g. availability of hardware keyboard is used by UI side to decide whether virtual keyboard should be shown or not. Differentiate between touch and mouse input devices within MCE, keep track of mouse device availability, and expose availability state on D-Bus as an enabler for UI showing or hiding mouse cursor. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
…5731 Based on input device capabilities YubiKey USB dongles look like full blown keyboards. This leads to virtual keyboard getting disabled when such dongle is attached. Add mce input device type configuration file that labels YubiKey devices as "user activity tracking only" type - using the dongle postpones display blanking etc, but does not affect virtual keyboard visibility. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
98a5d62
to
7df8a02
Compare
|
Review commits squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.