[charging] Configurable charging hysteresis. Fixes JB#40062 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python2 is deprecated and soon might not be available in sdk. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
mlehtima
reviewed
Feb 17, 2022
enable_limit has priority, so enable_limit=60, disable_limit=50 --acts-like--> enable_limit=60, disable_limit=61 but it is a illogical situation -> probably it would be better to handle it more explicitly... |
spiiroin
force-pushed
the
jb40062_charging_hysteresis
branch
from
f030d3b
to
47f1ff2
Compare
mlehtima
approved these changes
Feb 21, 2022
Keeping devices constantly connected to a charger (e.g. 24/7/365 in
case of devices used for running automated tests) can be detrimental
to battery health.
Make it possible to disable charging temporarily to reduce amount of time
devices are doing maintenance charging at close to battery full state.
Supported modes are:
- enable: charging is always enabled
- disable: charging is always disabled
- apply-thresholds: disabled at disable limit/above and enabled at
enable limit or below
- apply-thresholds-after-full: enabled until battery full is reached,
after which as with apply-thresholds
Enable/disable thresholds and operation mode can be modified during
runtime, for example with mcetool options:
--set-charging-mode=<mode>
--set-charging-enable-limit=<percent>
--set-charging-disable-limit=<percent>
How charging is enabled/disabled must be defined in mce configuration
file (see inifiles/charging.ini for details).
Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb40062_charging_hysteresis
branch
from
47f1ff2
to
632daf8
Compare
|
Review commits squashed and spec adjusted to have: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping devices constantly connected to a charger (e.g. 24/7/365 in
case of devices used for running automated tests) can be detrimental
to battery health.
Make it possible to disable charging temporarily to reduce amount of time
devices are doing maintenance charging at close to battery full state.
Supported modes are:
enable limit or below
after which as with apply-thresholds
Enable/disable thresholds and operation mode can be modified during
runtime, for example with mcetool options:
--set-charging-mode=
--set-charging-enable-limit=
--set-charging-disable-limit=
How charging is enabled/disabled must be defined in mce configuration
file (see inifiles/charging.ini for details).
Signed-off-by: Simo Piiroinen simo.piiroinen@jolla.com